Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use self instead of SimpleMemoryBackend #551

Closed
wants to merge 2 commits into from

Conversation

and-semakin
Copy link

@and-semakin and-semakin commented Oct 31, 2021

What do these changes do?

Use self instead of direct links to SimpleMemoryBackend class. This PR doesn't affect any functionality but allows users of the library inherit SimpleMemoryBackend and change its behaviour. Otherwise, changing the behavior is really difficult to do.

Are there changes in behavior for the user?

No.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@Fogapod
Copy link
Contributor

Fogapod commented Mar 18, 2022

This is not a correct fix since you still use global cache and handlers. They are not set on init.

EDIT: Sorry, I misunderstood the purpose of this PR initially. I just made a similar one that actually moves state to instance. This is otherwise a positive change

@and-semakin
Copy link
Author

@Fogapod exactly, I didn’t even try to fix the issue with global cache state. My only purpose here was just to make inheritance easier. It’s just one little step in the correct direction.

@Dreamsorcerer
Copy link
Member

Looks good, sorry for the delay. Could you update with latest master and ensure the tests are all passing. Thanks.

@Dreamsorcerer
Copy link
Member

I think this is solved now with #562. Please reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants