Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BaseCache an ABC #683

Merged
merged 13 commits into from
Mar 5, 2023
Merged

Make BaseCache an ABC #683

merged 13 commits into from
Mar 5, 2023

Commits on Mar 4, 2023

  1. Make BaseCache an abstract base class

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    0193759 View commit details
    Browse the repository at this point in the history

  2. Add BaseCache subclasses for unit tests

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    8e04127 View commit details
    Browse the repository at this point in the history

  3. Update fixtures for BaseCache tests

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    9336bb3 View commit details
    Browse the repository at this point in the history

  4. Update unit tests for abstract BaseCache

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    e403214 View commit details
    Browse the repository at this point in the history

  5. Remove unused changes

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    6ecbfda View commit details
    Browse the repository at this point in the history

  6. Update the changelog

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    886415a View commit details
    Browse the repository at this point in the history

  7. Update decorator unit tests for abstract BaseCache

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    135dfcd View commit details
    Browse the repository at this point in the history

  8. Define concrete SimpleMemoryBackend._close()

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    a9bc7de View commit details
    Browse the repository at this point in the history

  9. Update backend unit tests for abstract BaseCache

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    604b00d View commit details
    Browse the repository at this point in the history

  10. BaseCache._close() raises NotImplementedError

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    8caa687 View commit details
    Browse the repository at this point in the history

  11. Make backend base classes concrete

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    85c2ec5 View commit details
    Browse the repository at this point in the history

  12. Revert BaseCache._close() to concrete definition: pass

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    0fb9255 View commit details
    Browse the repository at this point in the history

  13. Update changelog for brevity

    @padraic-shafer
    padraic-shafer committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    db33461 View commit details
    Browse the repository at this point in the history