Close aiohttp response properly in Stream (#605)

* Close aiohttp response properly * Add changelog * Fix for windows
aio-libs · Jul 21, 2021 · 50421c4 · 50421c4
1 parent 8b3c578
commit 50421c4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGES/604.bugfix b/CHANGES/604.bugfix
@@ -0,0 +1 @@
+Fix issue with unclosed response object in attach/exec.
diff --git a/aiodocker/stream.py b/aiodocker/stream.py
@@ -109,15 +109,15 @@ async def write_in(self, data: bytes) -> None:
             await protocol._drain_helper()
 
     async def close(self) -> None:
-        if self._resp is not None:
+        if self._resp is None:
             return
         if self._closed:
             return
-        assert self._resp is not None
         self._closed = True
         transport = self._resp.connection.transport
-        transport.write_eof()
-        await self._resp.close()
+        if transport.can_write_eof():
+            transport.write_eof()
+        self._resp.close()
 
     async def __aenter__(self) -> "Stream":
         await self._init()