New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported docker version and clean tests a bit #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 83.73% 83.81% +0.07%
==========================================
Files 19 19
Lines 904 908 +4
==========================================
+ Hits 757 761 +4
Misses 147 147
Continue to review full report at Codecov.
|
Strange error.
It seems the docker daemon is closing the connection. |
Yes. |
69efa32
to
e00bdf3
Compare
I can't replicate the issue with docker api 1.32 locally....... |
e322634
to
c35a472
Compare
c195430
to
3122e21
Compare
Cool, finally ✅. Happy to drop support for DOCKER 17.09. |
2325333
to
5ff75f6
Compare
fcbca64
to
0ce5664
Compare
+1 |
What do these changes do?
docker image inspect
Are there changes in behavior for the user?
No.
Related issue number
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.