Origin driver issues: surrogatepass and scheme checking #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2017
froosty
reviewed
Jul 12, 2017
| @@ -52,7 +52,7 @@ def __init__( | |||
| self.verify_certs = verify_certs | |||
|
|
|||
| self.base_url = URL('http%s://%s:%d%s/' % ( | |||
| 's' if use_ssl else '', host, port, self.url_prefix, | |||
| 's' if self.use_ssl else '', host, port, self.url_prefix, | |||
There was a problem hiding this comment.
В оригинальном драйвере пробрасывается (пруф) scheme. А у нас scheme строится только на основе use_ssl. Это норм?
There was a problem hiding this comment.
@froosty у нас немає своєї логіки побудови scheme, вона інкапсульована в оригінальному драйвері
https://github.com/litwisha/aioelasticsearch/blob/origin-driver-issues/aioelasticsearch/connection.py#L34
There was a problem hiding this comment.
Maybe its better to stick with english guys, its not an inner project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port issues fixes from original
elasticsearch-pydriver: