Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to add Typing? #178

Open
Henddher opened this issue Sep 18, 2022 · 1 comment
Open

Plans to add Typing? #178

Henddher opened this issue Sep 18, 2022 · 1 comment

Comments

@Henddher
Copy link

Hi,

Any plans to add typing to all demos?

So far, it hasn't been too hard to add typing to my code using aiohttp's websockets. However, it is a bit tricky to navigate aiohttp's code to find what and where the types are.

I think that adding typing to all demos would help new comers.

@Dreamsorcerer
Copy link
Member

Feel free to make a PR (maybe 1 demo at a time). Ask any questions here or in the PR if you are unsure.

From what I've seen, it's pretty straightforward, and I don't normally need to look at the aiohttp code (atleast since we've added Handler and Middleware type aliases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants