Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Tracing #1309

Closed
hynek opened this issue Oct 13, 2016 · 5 comments
Closed

Client Tracing #1309

hynek opened this issue Oct 13, 2016 · 5 comments

Comments

@hynek
Copy link
Contributor

hynek commented Oct 13, 2016

Go 1.7 added tracing to its http client which I find quite intriguing:

The collected information can be used for debugging latency issues, service monitoring, writing adaptive systems, and more.

HTTP events

The httptrace package provides a number of hooks to gather information during an HTTP round trip about a variety of events. These events include:

  • Connection creation
  • Connection reuse
  • DNS lookups
  • Writing the request to the wire
  • Reading the response

Is that something you’d find a good fit for aiohttp?

@asvetlov
Copy link
Member

Brilliant idea.
Perhaps aiohttp signals could be reused for hooks implementation

@thehesiod
Copy link
Contributor

btw in a sorta related note I'm adding this to DataDog in this PR: DataDog/dd-trace-py#294

@asvetlov
Copy link
Member

If you want to pick up the issue (very complex task btw but we can eat an Elephant piece by piece) you are welcome.
It could not only avoid patching aiohttp code by DataDog but is very useful for other aiohttp users.

@asvetlov
Copy link
Member

Close for sake of #2313

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants