Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client exceptions refactoring #1661

Closed
fafhrd91 opened this issue Feb 19, 2017 · 5 comments
Closed

Client exceptions refactoring #1661

fafhrd91 opened this issue Feb 19, 2017 · 5 comments
Labels
Milestone

Comments

@fafhrd91
Copy link
Member

fafhrd91 commented Feb 19, 2017

New hierarchy of exceptions:

  • ClientError
    • ClientResponseError - exceptions that could happen after we get response from server
      • WSServerHandshakeError - web socket server response error
      • ClientHttpProxyError - proxy response
    • ClientConnectionError - exceptions related to low-level connection problem
      • ClientOSError - subset of connection errors that are initiated by OSError exception
        • ClientConnectorError - connector related exceptions
          • ClientProxyConnectionError` - proxy connection initialization error
      • ServerConnectionError - server connection related errors
        • ServerDisconnectedError - server disconnected
        • ServerTimeoutError - server operation timeout, (read timeout, etc)
        • ServerFingerprintMismatch - server fingerprint mistmach
@fafhrd91
Copy link
Member Author

@kxepal @asvetlov

@fafhrd91 fafhrd91 added this to the 2.0 milestone Feb 19, 2017
@asvetlov
Copy link
Member

I have strong temptation for dropping ClientError (for deprecation period we can make it as alias for Exception and deriving ClientConnectionError from OSError.
Sorry, I have no time for explaining my motivation right now but will try to describe my ideas tomorrow evening.

@fafhrd91
Copy link
Member Author

we can kill ClientRequestError and replace it with ValueError

@fafhrd91
Copy link
Member Author

ClientRequestError is removed

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants