Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp 3.5 release #3384

Closed
asvetlov opened this issue Nov 8, 2018 · 7 comments
Closed

aiohttp 3.5 release #3384

asvetlov opened this issue Nov 8, 2018 · 7 comments
Milestone

Comments

@asvetlov
Copy link
Member

asvetlov commented Nov 8, 2018

We are close to aiohttp 3.5.

My plan is:

  1. Review pending PRs: body thread helpers #3205 Add default logging handler to web.run_app (#3243) #3324 false-negative indicator end_of_HTTP_chunk in readchunk #3362 Release HTTP response before raising status exception #3365
  2. Make connector.close() returning a future as a step to converting it to async function in aiohttp 4.0
  3. Reformat code with black

Please feel free to add missing things in comments

@asvetlov asvetlov added this to the 3.5 milestone Nov 8, 2018
@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #3024 (aiohttp 3.3 release), #58 (aiohttp.HttpClient), #2224 (aiohttp.TCPConnector()), #1604 (aiohttp 1.3.0 sdist ?), and #467 (Failed building wheel for aiohttp on Python 3.5.0rc1).

@kxepal
Copy link
Member

kxepal commented Nov 8, 2018

#3364 - looks like useful fix, there is PR.
#3380 - feels like we have some tricky bug. Still in lazy debug process.

@achimnol
Copy link
Member

achimnol commented Nov 16, 2018

Hm, I think we should include a fix for adding closing/closed checks to aiohttp.web.WebSocketResponse's send_xxx() methods as I mentioned in the gitter channel.
I will make an issue -- #3391.

@asvetlov
Copy link
Member Author

Hi. I'd like to publish aiohttp 3.5 on this or next week (but defnitely in this year).
It was a long run, 3.4 was released 4 months ago.

If some bugs will be not fixed -- that's satisfactory, we can make a bugfix release later.

@asvetlov
Copy link
Member Author

aiohttp 3.5.0 has been released

@stonebig
Copy link

shouldn't the github 3.5 milestone be closed ?

@asvetlov
Copy link
Member Author

Good idea. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants