Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom router support #3545

Merged
merged 2 commits into from Jan 16, 2019
Merged

Drop custom router support #3545

merged 2 commits into from Jan 16, 2019

Conversation

asvetlov
Copy link
Member

No description provided.

@kxepal
Copy link
Member

kxepal commented Jan 16, 2019

😭 from aiohttp_traversal.

@asvetlov
Copy link
Member Author

I feel your pain, we discussed it several times.
The parameter is deprecated already.

@codecov-io
Copy link

Codecov Report

Merging #3545 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
- Coverage   97.93%   97.91%   -0.03%     
==========================================
  Files          43       43              
  Lines        8585     8581       -4     
  Branches     1385     1384       -1     
==========================================
- Hits         8408     8402       -6     
- Misses         73       74       +1     
- Partials      104      105       +1
Impacted Files Coverage Δ
aiohttp/web_app.py 98.87% <100%> (-0.02%) ⬇️
aiohttp/web_request.py 97.44% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a64b2...0cec079. Read the comment docs.

@kxepal
Copy link
Member

kxepal commented Jan 16, 2019

Yeah, I know. It's just quite strange to implement router thought router with the new design.

Copy link
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with a grief.

@asvetlov asvetlov merged commit c7c2d4c into master Jan 16, 2019
@asvetlov asvetlov deleted the forbid-custom-router branch January 16, 2019 18:33
@lock
Copy link

lock bot commented Jan 16, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants