Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing TestClient.scheme property #3721

Merged
merged 1 commit into from May 6, 2019
Merged

Add the missing TestClient.scheme property #3721

merged 1 commit into from May 6, 2019

Conversation

emilmelnikov
Copy link
Contributor

What do these changes do?

Add the missing TestClient.scheme property that is mentioned in the testing documentation but has not been implemented.

Are there changes in behavior for the user?

Users can access the scheme property of the test client:

async def test_spam(aiohttp_client):
    client = aiohttp_client(my_app_factory())
    assert client.scheme == 'http'

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #3721 into master will decrease coverage by 3.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3721      +/-   ##
=========================================
- Coverage   97.88%   94.4%   -3.49%     
=========================================
  Files          43      43              
  Lines        8559    8561       +2     
  Branches     1377    1376       -1     
=========================================
- Hits         8378    8082     -296     
- Misses         75     360     +285     
- Partials      106     119      +13
Impacted Files Coverage Δ
aiohttp/test_utils.py 97.76% <100%> (-1.6%) ⬇️
aiohttp/worker.py 6.55% <0%> (-90.99%) ⬇️
aiohttp/resolver.py 46.55% <0%> (-53.45%) ⬇️
aiohttp/web_fileresponse.py 66.66% <0%> (-29.89%) ⬇️
aiohttp/tcp_helpers.py 63.33% <0%> (-26.67%) ⬇️
aiohttp/typedefs.py 91.3% <0%> (-8.7%) ⬇️
aiohttp/pytest_plugin.py 89.79% <0%> (-7.49%) ⬇️
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_runner.py 91.7% <0%> (-6.22%) ⬇️
aiohttp/__init__.py 94.44% <0%> (-5.56%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9504fe2...5faeccb. Read the comment docs.

@asvetlov asvetlov merged commit 4dc41aa into aio-libs:master May 6, 2019
@asvetlov
Copy link
Member

asvetlov commented May 6, 2019

Thanks!

@lock lock bot added the outdated label May 5, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants