You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🐣 Is your feature request related to a problem? Please describe.
It seems inconvenient that you don't know the signature of a method when using it. If you are coming from different libraries, like request or maybe you've used the aiohttp Client some time ago, you kinda know that there is probably params like auth, timeout, headers, and some other basic stuff, so it would be really convenient to not check the docs or source code, and have IDE to suggest you these params.
The other thing with this is that auth, for example, should be an instance of a BasicAuth, wherein requests it could be just a tuple. If we would have a signature beforehand, the IDE or mypy would be able to detect the error before executing the code.
💡 Describe the solution you'd like
One possibility is to duplicate the whole signature, instead of using kwargs. From the code perspective probably not the best idea, but it could help end-users.
❓ Describe alternatives you've considered
I've also thought about making kwargs fully typed, but it doesn't look like mypy can handle this. I definitely can check this again if you think that this is a good idea.
📋 Additional context
Additionally, I would like to say that I'm willing to work on this if the community decides that this feature could add value to the project.
Thanks for the great library!
The text was updated successfully, but these errors were encountered:
🐣 Is your feature request related to a problem? Please describe.
It seems inconvenient that you don't know the signature of a method when using it. If you are coming from different libraries, like request or maybe you've used the aiohttp Client some time ago, you kinda know that there is probably params like
auth
,timeout
,headers
, and some other basic stuff, so it would be really convenient to not check the docs or source code, and have IDE to suggest you these params.The other thing with this is that auth, for example, should be an instance of a BasicAuth, wherein requests it could be just a tuple. If we would have a signature beforehand, the IDE or mypy would be able to detect the error before executing the code.
💡 Describe the solution you'd like
One possibility is to duplicate the whole signature, instead of using kwargs. From the code perspective probably not the best idea, but it could help end-users.
❓ Describe alternatives you've considered
I've also thought about making kwargs fully typed, but it doesn't look like mypy can handle this. I definitely can check this again if you think that this is a good idea.
📋 Additional context
Additionally, I would like to say that I'm willing to work on this if the community decides that this feature could add value to the project.
Thanks for the great library!
The text was updated successfully, but these errors were encountered: