_pong_response_cb does not close websocket

[louisabraham]

I'm running a web app and have the infamous socket.send() raised exception. bug.

I cannot give any reproducible example but I ran the loop in a thread, thus giving me access to the REPL.

I created my WebSocket with web.WebSocketResponse(heartbeat=5).

The problem seems to be that _pong_not_received was called but did not close the websocket. The REPL indicates that ws._req.transport is None, which is the reason why it does not do anything.

aiohttp/aiohttp/web_ws.py

Lines 113 to 118 in 48bf8c3

	def _pong_not_received(self) -> None:
	if self._req is not None and self._req.transport is not None:
	self._closed = True
	self._close_code = 1006
	self._exception = asyncio.TimeoutError()
	self._req.transport.close()

Why is the condition checked? I think the assumptions are too strong and the check should only be made before calling self._req.transport.close().