Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with pep8-1.6 #494

Closed
vbraun opened this issue Sep 4, 2015 · 3 comments
Closed

Tests fail with pep8-1.6 #494

vbraun opened this issue Sep 4, 2015 · 3 comments
Labels

Comments

@vbraun
Copy link

vbraun commented Sep 4, 2015

The updated pep8 introduces a new E402. It doesn't seem too important, so maybe ignore it globally?

$ make flake
flake8 aiohttp tests examples
aiohttp/web_exceptions.py:48:1: E402 module level import not at top of file
aiohttp/web.py:19:1: E402 module level import not at top of file
aiohttp/web.py:21:1: E402 module level import not at top of file
aiohttp/web.py:22:1: E402 module level import not at top of file
aiohttp/web.py:23:1: E402 module level import not at top of file
aiohttp/web.py:24:1: E402 module level import not at top of file
aiohttp/helpers.py:331:5: W503 line break before binary operator
aiohttp/web_ws.py:3:1: E402 module level import not at top of file
aiohttp/web_ws.py:4:1: E402 module level import not at top of file
aiohttp/web_ws.py:6:1: E402 module level import not at top of file
aiohttp/web_ws.py:7:1: E402 module level import not at top of file
aiohttp/web_ws.py:8:1: E402 module level import not at top of file
aiohttp/web_ws.py:9:1: E402 module level import not at top of file
aiohttp/web_ws.py:10:1: E402 module level import not at top of file
aiohttp/web_ws.py:12:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:4:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:5:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:7:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:8:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:9:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:10:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:11:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:13:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:15:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:16:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:17:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:18:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:19:1: E402 module level import not at top of file
aiohttp/web_urldispatcher.py:20:1: E402 module level import not at top of file
aiohttp/multipart.py:629:13: W503 line break before binary operator
aiohttp/multipart.py:630:13: W503 line break before binary operator
aiohttp/multipart.py:707:26: W503 line break before binary operator
aiohttp/web_reqrep.py:3:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:4:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:5:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:6:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:7:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:8:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:9:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:10:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:11:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:12:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:13:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:15:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:17:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:18:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:19:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:21:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:22:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:23:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:27:1: E402 module level import not at top of file
aiohttp/web_reqrep.py:28:1: E402 module level import not at top of file
Makefile:8: recipe for target 'flake' failed
make: *** [flake] Error 1
@kxepal
Copy link
Member

kxepal commented Sep 4, 2015

Fix is quite trivial: put __all__ definition after imports.

@asvetlov
Copy link
Member

asvetlov commented Sep 4, 2015

Thanks. Fixed.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants