Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.3 support #537

Closed
asvetlov opened this issue Sep 30, 2015 · 5 comments
Closed

Drop python 3.3 support #537

asvetlov opened this issue Sep 30, 2015 · 5 comments
Labels
outdated

Comments

@asvetlov
Copy link
Member

We are rely on __del__ in the library a lot.
For graceful finalization for bare aiohttp.request() and family after merging #536 we should do session detach in https://github.com/KeepSafe/aiohttp/pull/536/files#diff-7dd84b5ef8d5eea2de1dfc5329411dfcR472

It doesn't work on Python 3.3. I can add weakref tricks, sure. But prefer dropping Python 3.3 at all.

Thoughts?
@fafhrd91
Copy link
Member

+1

1 similar comment
@ludovic-gasc
Copy link
Contributor

+1

@asvetlov asvetlov mentioned this issue Oct 1, 2015
Merged
@carlcarl
Copy link
Contributor

carlcarl commented Oct 3, 2015

Should be closed?

@asvetlov
Copy link
Member Author

asvetlov commented Oct 3, 2015

Sure, thanks

@asvetlov asvetlov closed this as completed Oct 3, 2015
@jettify jettify mentioned this issue Oct 3, 2015
Closed
@aio-libs-bot aio-libs-bot mentioned this issue Dec 21, 2018
Closed
@aio-libs-bot aio-libs-bot mentioned this issue Jan 3, 2019
Closed
@aio-libs-bot aio-libs-bot mentioned this issue Feb 13, 2019
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ludovic-gasc @asvetlov @fafhrd91 @carlcarl