New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove import aliases #7153
remove import aliases #7153
Conversation
987e5b5
to
207ebe3
Compare
AsyncResolver as AsyncResolver, | ||
DefaultResolver as DefaultResolver, | ||
ThreadedResolver as ThreadedResolver, | ||
PAYLOAD_REGISTRY, |
Check warning
Code scanning / CodeQL
Importing value of mutable attribute
Codecov Report
@@ Coverage Diff @@
## master #7153 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 106 106
Lines 31093 31093
Branches 3875 3875
=======================================
Hits 30278 30278
Misses 613 613
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
These were probably done like this as an explicit reexport: https://mypy.readthedocs.io/en/stable/config_file.html?highlight=reexport#confval-implicit_reexport As we add all of them to |
for more information, see https://pre-commit.ci
7455c00
to
f955af4
Compare
Right, this was introduced for mypy 0.710 which added the explicit reexport option. Support for (I removed the change file as there should be no visible change to the user). |
I'll add the 3.9 backport flag, but I'm sure it will fail to backport automatically.. |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 4635161 on top of patchback/backports/3.9/4635161ee8e7ad321cca46e01ce5bfeb1ad8bf26/pr-7153 Backporting merged PR #7153 into master
🤖 @patchback |
What do these changes do?
Clean up imports by removing import aliases
Are there changes in behavior for the user?
No
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.