Tightening the runtime type check for ssl (#7698) #8042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None. If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird. In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Sam Bull <git@sambull.org> (cherry picked from commit 9e14ea1)
psf-chronographer
bot
added
the
bot:chronographer:provided
Dreamsorcerer
commented
Jan 20, 2024
Dreamsorcerer
commented
Jan 20, 2024
Dreamsorcerer
added
the
backport-3.9
Dreamsorcerer
commented
Jan 20, 2024
Dreamsorcerer
commented
Jan 20, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8042 +/- ##
==========================================
- Coverage 97.40% 97.39% -0.01%
==========================================
Files 108 108
Lines 32810 32813 +3
Branches 3902 3903 +1
==========================================
Hits 31958 31958
- Misses 648 650 +2
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
deleted the
patchback/backports/3.10/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698
branch
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8043 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 20, 2024
Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None. If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird. In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Sam Bull <git@sambull.org> (cherry picked from commit 9e14ea1) (cherry picked from commit 4b91b53)
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Jan 21, 2024
…or ssl (#7698) (#8043) **This is a backport of PR #8042 as merged into 3.10 (4b91b53).** Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None. If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird. In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Sam Bull <git@sambull.org> (cherry picked from commit 9e14ea1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None.
If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird.
In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context.
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko wk.cvs.github@sydorenko.org.ua
Co-authored-by: Sam Bull aa6bs0@sambull.org
Co-authored-by: J. Nick Koston nick@koston.org
Co-authored-by: Sam Bull git@sambull.org
(cherry picked from commit 9e14ea1)
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.