Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v3.9.2 #8082

Merged
merged 10 commits into from Jan 28, 2024
Merged

Release v3.9.2 #8082

merged 10 commits into from Jan 28, 2024

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9118a58) 97.30% compared to head (ff9ca9e) 97.30%.

Additional details and impacted files 
@@           Coverage Diff           @@
##              3.9    #8082   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files         108      108           
  Lines       32632    32632           
  Branches     3872     3872           
=======================================
  Hits        31754    31754           
  Misses        671      671           
  Partials      207      207
Flag Coverage Δ
CI-GHA 97.22% <100.00%> (ø)
OS-Linux 96.91% <100.00%> (ø)
OS-Windows 94.41% <ø> (ø)
OS-macOS 96.53% <100.00%> (-0.20%) ⬇️
Py-3.10.11 94.31% <ø> (ø)
Py-3.10.13 96.69% <100.00%> (ø)
Py-3.11.7 96.42% <100.00%> (-0.04%) ⬇️
Py-3.12.1 96.48% <100.00%> (-0.03%) ⬇️
Py-3.8.10 94.29% <ø> (-0.01%) ⬇️
Py-3.8.18 96.62% <100.00%> (ø)
Py-3.9.13 94.30% <ø> (ø)
Py-3.9.18 96.68% <100.00%> (ø)
Py-pypy7.3.15 96.22% <100.00%> (ø)
VM-macos 96.53% <100.00%> (-0.20%) ⬇️
VM-ubuntu 96.91% <100.00%> (ø)
VM-windows 94.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
Dreamsorcerer and others added 2 commits January 28, 2024 19:21
@Dreamsorcerer @webknjaz
Update CHANGES.rst
c689715 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
@Dreamsorcerer @webknjaz
Update CHANGES.rst
31fd648 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
@Dreamsorcerer @webknjaz
Update CHANGES.rst
9346b7b 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
Dreamsorcerer and others added 5 commits January 28, 2024 19:24
@Dreamsorcerer
Update CHANGES.rst
34eb65a
@Dreamsorcerer
Update CHANGES.rst
ecd0289
@Dreamsorcerer
Update CHANGES.rst
6db6975
@Dreamsorcerer @webknjaz
Update CHANGES.rst
46d0446 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
@Dreamsorcerer
Update CHANGES.rst
5aa2d5d
webknjaz
webknjaz reviewed Jan 28, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer merged commit 24a6d64 into 3.9 Jan 28, 2024
27 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the release/v3.9.2 branch January 28, 2024 20:38
@webknjaz
Copy link
Member

FTR I just approved the PyPI upload in the GHA job. It should complete soon.

@bdraco
Copy link
Member

bdraco commented Jan 28, 2024

Retested the final version on production. Everything looks good. Thanks for getting this out.

webknjaz
webknjaz reviewed Jan 30, 2024
View reviewed changes
CHANGES/8010.doc
@@ -1,2 +0,0 @@
On the `CHANGES/README.rst <https://github.com/aio-libs/aiohttp/tree/master/CHANGES/README.rst>`_ page,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dreamsorcerer did you decide not to include this fragment into the resulting changelog? Why? Now, this change note only exists on master and shows up in the changelog draft for 4.0: https://docs.aiohttp.org/en/latest/changes.html.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, removal of this fragment didn't happen in 3.10 either: 0124dc5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dreamsorcerer I checked the fragment list and this seems to be the only one that disappeared mysteriously.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, not sure. Must have done something weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dreamsorcerer @webknjaz @bdraco