📝💅 Ask PR submitters about the complexities #8099

webknjaz · 2024-01-29T13:59:38Z

I envision this may help the contributors and the maintainers be more mindful regarding what goes into the repository, by illuminating the connected burdens of maintaining the contributions long-term.

What do these changes do?

$sbj.

Are there changes in behavior for the user?

Nope.

Related issue number

N/A

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
If you provide code modification, please add yourself to CONTRIBUTORS.txt
- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
Add a new news fragment into the CHANGES/ folder
- name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)
- if you don't have an issue number, change it to the pull request
  number after creating the PR
  - .bugfix: A bug fix for something the maintainers deemed an
    improper undesired behavior that got corrected to match
    pre-agreed expectations.
  - .feature: A new behavior, public APIs. That sort of stuff.
  - .deprecation: A declaration of future API removals and breaking
    changes in behavior.
  - .breaking: When something public is removed in a breaking way.
    Could be deprecated in an earlier release.
  - .doc: Notable updates to the documentation structure or build
    process.
  - .packaging: Notes for downstreams about unobvious side effects
    and tooling. Changes in the test invocation considerations and
    runtime assumptions.
  - .contrib: Stuff that affects the contributor experience. e.g.
    Running tests, building the docs, setting up the development
    environment.
  - .misc: Changes that are hard to assign to any of the above
    categories.
- Make sure to use full sentences with correct case and punctuation,
  for example:
```
Fixed issue with non-ascii contents in doctest text files
-- by :user:`contributor-gh-handle`.
```
  Use the past tense or the present tense a non-imperative mood,
  referring to what's changed compared to the last released version
  of this project.

I envision this may help the contributors and the maintainers be more mindful regarding what goes into the repository, by illuminating the connected burdens of maintaining the contributions long-term.

codecov · 2024-01-29T14:09:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b2eebd) 97.41% compared to head (704f630) 97.41%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8099   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         107      107           
  Lines       32732    32732           
  Branches     3823     3823           
=======================================
  Hits        31885    31885           
  Misses        640      640           
  Partials      207      207

Flag	Coverage Δ
CI-GHA	`97.32% <ø> (ø)`
OS-Linux	`96.99% <ø> (ø)`
OS-Windows	`95.50% <ø> (ø)`
OS-macOS	`96.63% <ø> (-0.19%)`	⬇️
Py-3.10.11	`95.43% <ø> (ø)`
Py-3.10.13	`96.80% <ø> (ø)`
Py-3.11.7	`96.46% <ø> (-0.03%)`	⬇️
Py-3.12.1	`96.59% <ø> (-0.03%)`	⬇️
Py-3.8.10	`95.40% <ø> (ø)`
Py-3.8.18	`96.74% <ø> (ø)`
Py-3.9.13	`95.40% <ø> (ø)`
Py-3.9.18	`96.77% <ø> (-0.01%)`	⬇️
Py-pypy7.3.15	`96.33% <ø> (ø)`
VM-macos	`96.63% <ø> (-0.19%)`	⬇️
VM-ubuntu	`96.99% <ø> (ø)`
VM-windows	`95.50% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dreamsorcerer · 2024-01-29T15:15:37Z

Yeah, looks OK, but the more requirements we add to the page, the less likely they'll be read, or the less likely we'll get contributions. I don't mind either way on this.

webknjaz · 2024-01-29T15:57:54Z

Yeah, I was thinking about linking the doc regarding the changelog instead of enumerating stuff too. But haven't decided.

patchback · 2024-01-30T00:36:41Z

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/3aa243ae89c597b5576863a7ac309732f6756151/pr-8099

Backported as #8106

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2024-01-30T00:36:41Z

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/3aa243ae89c597b5576863a7ac309732f6756151/pr-8099

Backported as #8105

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

PR #8099 (cherry picked from commit 3aa243a)

…plexities (#8106) **This is a backport of PR #8099 as merged into master (3aa243a).** I envision this may help the contributors and the maintainers be more mindful regarding what goes into the repository, by illuminating the connected burdens of maintaining the contributions long-term. ## What do these changes do? $sbj. ## Are there changes in behavior for the user? Nope. ## Related issue number N/A ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [x] Documentation reflects the changes - [x] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>

…lexities (#8105) **This is a backport of PR #8099 as merged into master (3aa243a).** I envision this may help the contributors and the maintainers be more mindful regarding what goes into the repository, by illuminating the connected burdens of maintaining the contributions long-term. ## What do these changes do? $sbj. ## Are there changes in behavior for the user? Nope. ## Related issue number N/A ## Checklist - [ ] I think the code is well written - [ ] Unit tests for the changes exist - [x] Documentation reflects the changes - [x] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>

📝💅 Ask PR submitters about the complexities

704f630

I envision this may help the contributors and the maintainers be more mindful regarding what goes into the repository, by illuminating the connected burdens of maintaining the contributions long-term.

webknjaz added the meta label Jan 29, 2024

webknjaz requested review from bdraco and Dreamsorcerer January 29, 2024 13:59

📝 Add a change note for PR aio-libs#8099

b996f37

webknjaz requested a review from asvetlov as a code owner January 30, 2024 00:35

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 30, 2024

webknjaz merged commit 3aa243a into aio-libs:master Jan 30, 2024
23 of 27 checks passed

webknjaz added backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Jan 30, 2024

patchback bot pushed a commit that referenced this pull request Jan 30, 2024

Merge branch 'maintenance/pr-template-burden-question'

846c8a0

PR #8099 (cherry picked from commit 3aa243a)

patchback bot pushed a commit that referenced this pull request Jan 30, 2024

Merge branch 'maintenance/pr-template-burden-question'

871d437

PR #8099 (cherry picked from commit 3aa243a)

This was referenced Jan 30, 2024

[PR #8099/3aa243ae backport][3.9] 📝💅 Ask PR submitters about the complexities #8105

Merged

[PR #8099/3aa243ae backport][3.10] 📝💅 Ask PR submitters about the complexities #8106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📝💅 Ask PR submitters about the complexities #8099

📝💅 Ask PR submitters about the complexities #8099

webknjaz commented Jan 29, 2024

codecov bot commented Jan 29, 2024 •

edited

Dreamsorcerer commented Jan 29, 2024

webknjaz commented Jan 29, 2024

patchback bot commented Jan 30, 2024 •

edited

patchback bot commented Jan 30, 2024 •

edited

📝💅 Ask PR submitters about the complexities #8099

📝💅 Ask PR submitters about the complexities #8099

Conversation

webknjaz commented Jan 29, 2024

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

codecov bot commented Jan 29, 2024 • edited

Codecov Report

Dreamsorcerer commented Jan 29, 2024

webknjaz commented Jan 29, 2024

patchback bot commented Jan 30, 2024 • edited

Backport to 3.10: 💚 backport PR created

patchback bot commented Jan 30, 2024 • edited

Backport to 3.9: 💚 backport PR created

codecov bot commented Jan 29, 2024 •

edited

patchback bot commented Jan 30, 2024 •

edited

patchback bot commented Jan 30, 2024 •

edited