after upgrading from 3.8.6 to 3.9.* can't use middlewares anymore

[electronick]

Describe the bug

I'm using aoihttp with standard middlewares like this:

from aiohttp import web
from aiohttp_middlewares import error_middleware, https_middleware

async def make_app():
    app = web.Application(middlewares=[
        error_middleware(ignore_exceptions=web.HTTPFound),
        https_middleware(),
    ])

after upgrading aiohttp package from 3.8.6 to any of 3.9.* verions (tried all of them) I get an error:

ImportError: cannot import name '_Middleware' from 'aiohttp.web_middlewares' 

and can't start server anymore.

Would appreciate any information regarding what should I change in my code in order for it to work.

To Reproduce

Upgrade from 3.8.6 to 3.9.0, 3.9.1, 3.9.2 or 3.9.3

Expected behavior

I wan't able to find any upgrade notes, so I assumed that new version should work would any changes to the code.

Logs/tracebacks

Traceback (most recent call last):
  File "/Users/nick/work/deploy_server/start_aio.py", line 7, in <module>
    from aiohttp_middlewares import error_middleware, https_middleware
  File "/Users/nick/work/deploy_server/venv/lib/python3.10/site-packages/aiohttp_middlewares/__init__.py", line 14, in <module>
    from aiohttp_middlewares.cors import cors_middleware
  File "/Users/nick/work/deploy_server/venv/lib/python3.10/site-packages/aiohttp_middlewares/cors.py", line 122, in <module>
    from aiohttp_middlewares.annotations import (
  File "/Users/nick/work/deploy_server/venv/lib/python3.10/site-packages/aiohttp_middlewares/annotations.py", line 22, in <module>
    from aiohttp.web_middlewares import _Middleware as Middleware
ImportError: cannot import name '_Middleware' from 'aiohttp.web_middlewares' (/Users/nick/work/deploy_server/venv/lib/python3.10/site-packages/aiohttp/web_middlewares.py)

### Python Version

```console
$ venv/bin/python --version
Python 3.10.13

aiohttp Version

$ venv/bin/python -m pip show aiohttp
Name: aiohttp
Version: 3.9.3
Summary: Async http client/server framework (asyncio)
Home-page: https://github.com/aio-libs/aiohttp
Author: 
Author-email: 
License: Apache 2
Location: /Users/nick/work/deploy_server/venv/lib/python3.10/site-packages
Requires: aiosignal, async-timeout, attrs, frozenlist, multidict, yarl
Required-by: aiogithubapi, aiohttp-middlewares, aiohttp-session, aiohttp_remotes, pytest-aiohttp

multidict Version

$ venv/bin/python -m pip show multidict
Name: multidict
Version: 6.0.4
Summary: multidict implementation
Home-page: https://github.com/aio-libs/multidict
Author: Andrew Svetlov
Author-email: andrew.svetlov@gmail.com
License: Apache 2
Location: /Users/nick/work/deploy_server/venv/lib/python3.10/site-packages
Requires: 
Required-by: aiohttp, yarl

yarl Version

$ venv/bin/python -m pip show yarl
Name: yarl
Version: 1.8.2
Summary: Yet another URL library
Home-page: https://github.com/aio-libs/yarl/
Author: Andrew Svetlov
Author-email: andrew.svetlov@gmail.com
License: Apache 2
Location: /Users/nick/work/deploy_server/venv/lib/python3.10/site-packages
Requires: idna, multidict
Required-by: aiohttp, aiohttp-middlewares

OS

macOS 14.3

Related component

Server

Additional context

No response

Code of Conduct

• I agree to follow the aio-libs Code of Conduct

[bdraco]

I think you need to upgrade https://github.com/playpauseandstop/aiohttp-middlewares

https://github.com/playpauseandstop/aiohttp-middlewares/blob/1701fae61236afa6054ceaf86b97181f86ea95b9/src/aiohttp_middlewares/annotations.py#L26

[Dreamsorcerer]

Yep, those are not the "standard" middlewares, they are a 3rd party package. If they've not released a fix, then you'll need to open an issue there.

Problem is that they were importing a private variable. We promoted that to a public variable to make it officially part of the API, so it can't find the private one anymore. As per the link above, it appears they've already updated the library to support 3.9+.

[electronick]

Guys, thank you so much for your help! Indeed, the problem was connected to outdated aiohttp-middlewares package and I didn't notice that it's listed separately.