Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking I/O in the event loop while processing files in a post request #8283

Merged
merged 6 commits into from Apr 5, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 2, 2024

What do these changes do?

Fix blocking I/O in the event loop while processing files in a post request

It looks like this was introduced in f2dbdf9

Are there changes in behavior for the user?

event loop is not blocked

Is it a substantial burden for the maintainers to support this?

no

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@bdraco bdraco added backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (add3937) to head (e5b2c9b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8283      +/-   ##
==========================================
+ Coverage   97.49%   97.56%   +0.06%     
==========================================
  Files         107      107              
  Lines       32987    32990       +3     
  Branches     3853     3853              
==========================================
+ Hits        32162    32187      +25     
+ Misses        606      588      -18     
+ Partials      219      215       -4     
Flag Coverage Δ
CI-GHA 97.48% <100.00%> (+0.05%) ⬆️
OS-Linux 97.14% <100.00%> (+0.05%) ⬆️
OS-Windows 95.71% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.85% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.70% <100.00%> (?)
Py-3.10.14 96.92% <100.00%> (+<0.01%) ⬆️
Py-3.11.8 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.26% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.53% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.89% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.53% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 ?
Py-3.9.19 96.92% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.15 96.45% <100.00%> (?)
VM-macos 96.85% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.14% <100.00%> (+0.05%) ⬆️
VM-windows 95.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 2, 2024
@bdraco bdraco marked this pull request as ready for review April 2, 2024 21:21
CHANGES/8283.bugfix.rst Outdated Show resolved Hide resolved
bdraco and others added 3 commits April 3, 2024 07:03
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
@bdraco
Copy link
Member Author

bdraco commented Apr 5, 2024

Production test on this one is good as well

@bdraco bdraco merged commit 54e13b0 into master Apr 5, 2024
36 of 37 checks passed
@bdraco bdraco deleted the post_blocking_io branch April 5, 2024 03:28
Copy link
Contributor

patchback bot commented Apr 5, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/54e13b0a2a2ac52cedaaa3837f9e93de220a423f/pr-8283

Backported as #8293

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 5, 2024
…equest (#8283)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
(cherry picked from commit 54e13b0)
Copy link
Contributor

patchback bot commented Apr 5, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/54e13b0a2a2ac52cedaaa3837f9e93de220a423f/pr-8283

Backported as #8294

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 5, 2024
…equest (#8283)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
(cherry picked from commit 54e13b0)
bdraco added a commit that referenced this pull request Apr 5, 2024
…while processing files in a post request (#8293)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Apr 5, 2024
… while processing files in a post request (#8294)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.9 Trigger automatic backporting to the 3.9 release branch by Patchback robot backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants