Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about ServerHttpProtocol.closing() #172

Closed
asvetlov opened this issue Nov 6, 2014 · 2 comments
Closed

Question about ServerHttpProtocol.closing() #172

asvetlov opened this issue Nov 6, 2014 · 2 comments
Labels

Comments

@asvetlov
Copy link
Member

asvetlov commented Nov 6, 2014

The method doesn't reset self.transport to None after self.transport.close() call.
That means self.transport.close() will be called on next .closing() call again.

I see nothing wrong with it because asyncio transports correctly process double .close() calls but maybe adding line like self.transport = None make code a bit more accurate?

@fafhrd91
Copy link
Member

+1

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants