Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto patch ssl for Python 3.7- #2674

Closed
hellysmile opened this issue Jan 21, 2018 · 1 comment
Closed

Auto patch ssl for Python 3.7- #2674

hellysmile opened this issue Jan 21, 2018 · 1 comment
Labels

Comments

@hellysmile
Copy link
Member

Long story short

Proposal to fix #949

There is an idea discussed with @asvetlov offline: automatically patch Python runtime by https://github.com/aio-libs/idna_ssl if Python version is lower then 3.7

Expected behaviour

ssl.CertificateError works correct for idna hosts

Actual behaviour

ssl.CertificateError is raised

Steps to reproduce

import asyncio

import aiohttp

URL = 'https://цфоут.мвд.рф/news/item/8065038/'


async def main():
    async with aiohttp.ClientSession() as session:
        async with session.get(URL) as response:
            print(response)


loop = asyncio.get_event_loop()
loop.run_until_complete(main())

Your environment

aiohttp server master
Python 3.6.2

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant