Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request.content.iter_chunks() stalls when content is empty. #3186

Closed
ArthurKantor opened this issue Aug 10, 2018 · 3 comments · Fixed by #3295
Closed

request.content.iter_chunks() stalls when content is empty. #3186

ArthurKantor opened this issue Aug 10, 2018 · 3 comments · Fixed by #3295
Labels
outdated

Comments

@ArthurKantor
Copy link

ArthurKantor commented Aug 10, 2018 •
edited
Loading

Long story short

The title says it all.

Shouldn't EmptyStreamReader.readchunk on its face return (b'', True) and not return (b'', False) ?

Without it, the special EOS chunk is never sent...
@webknjaz
Copy link
Member

Could you please describe your scenario in more detail?

asvetlov added a commit that referenced this issue Sep 26, 2018
@asvetlov
Fix #3186: Return empty bytes with end-of-chunk marker in empty strea…
b4063a9 
…m reader.
@asvetlov
Copy link
Member

The feature request makes sense.

@asvetlov asvetlov mentioned this issue Sep 26, 2018
Merged
asvetlov added a commit that referenced this issue Sep 26, 2018
@asvetlov
Fix #3186: Return empty bytes with end-of-chunk marker in empty strea…
27b586b 
…m reader. (#3295)
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return empty bytes with end-of-chunk marker in empty stream reader aio-libs/aiohttp
3 participants
@asvetlov @webknjaz @ArthurKantor