Skip to content

Commit

Permalink
Allow group coordinator to close when all brokers are unavailable (#660)
Browse files Browse the repository at this point in the history
Fixes #659
  • Loading branch information
dkilgore90 committed Nov 13, 2020
1 parent f7f55b1 commit fff2c02
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog
=========


659.bugfix
Allow group coordinator to close when all brokers are unavailable


0.7.0 (2020-10-28)
==================

Expand Down
2 changes: 1 addition & 1 deletion aiokafka/consumer/group_coordinator.py
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ async def ensure_coordinator_known(self):

async with self._coordinator_lookup_lock:
retry_backoff = self._retry_backoff_ms / 1000
while self.coordinator_id is None:
while self.coordinator_id is None and not self._closing.done():
try:
coordinator_id = (
await self._client.coordinator_lookup(
Expand Down

0 comments on commit fff2c02

Please sign in to comment.