Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Potential dependency on crc32c package #913

Closed
rtobar opened this issue Aug 6, 2023 · 0 comments
Closed

[QUESTION] Potential dependency on crc32c package #913

rtobar opened this issue Aug 6, 2023 · 0 comments
Labels

Comments

@rtobar
Copy link

rtobar commented Aug 6, 2023

Hi,

I'm not sure how much inter-communication there is between this project and kafka-python, so I'm opening a separate ticket here to discuss an idea I discussed over there that applies to this project as well. This is more of a discussion really, but I couldn't see the "Discussions" section enabled on this project, so I'm filing it as a "question" issue instead.

In dpkp/kafka-python#2380 I mention how during some profiling we observed some bottlenecks around crc32c calculation because, for some reason, the python fallback routines were being used. After doing a deep dive, I found that both this project and kafka-python have python fallbacks, while at the same time catering for faster versions of the checksums: this project ships with its own C/Cython-based extension, while kafka-python optionally uses the crc32c package.

My question there, and now here, is: would you consider adding a hard dependency on crc32c to avoid having python fallbacks in the first place, while also not having to maintain a C/Cython-based module for this purpose?

Please see the above thread for a longer discussion, and thanks in advance for any consideration given to this idea.

@rtobar rtobar added the question label Aug 6, 2023
@aio-libs aio-libs locked and limited conversation to collaborators Aug 6, 2023
@ods ods converted this issue into discussion #914 Aug 6, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

1 participant