Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0 zstd codec depends on cramjam but missing in documentation #952

Closed
iamwrm opened this issue Dec 14, 2023 · 1 comment
Closed

0.9.0 zstd codec depends on cramjam but missing in documentation #952

iamwrm opened this issue Dec 14, 2023 · 1 comment

Comments

@iamwrm
Copy link

iamwrm commented Dec 14, 2023

Describe the bug

Hi. I found zstd compression support needs cramjam

https://github.com/aio-libs/aiokafka/blob/881851783673e927591ba274a7703c9b52d387ac/aiokafka/codec.py#L10C19-L10C19

But the doc still says pip install aiokafka[zstd], while 0.9.0 doesn't even have this option.

pip install 'aiokafka[zstd]'

Environment (please complete the following information):

  • aiokafka version (python -c "import aiokafka; print(aiokafka.__version__)"): 0.9.0
  • Kafka Broker version (kafka-topics.sh --version): redpanda
  • Other information (Confluent Cloud version, etc.):

If this bug does confirm to exist, I would love to open a PR to fix the doc.

ods added a commit to ods/aiokafka that referenced this issue Dec 14, 2023
ods added a commit to ods/aiokafka that referenced this issue Dec 14, 2023
ods added a commit that referenced this issue Dec 15, 2023
@ods
Copy link
Collaborator

ods commented Dec 15, 2023

Should be fixed in 0.10.0

@ods ods closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants