Fast fix for issue #88. Coordinator race condition #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is not good enough. It will not fix issue with adding topics to subscribtion, as no conflict will occur. |
tvoinarovskyi
force-pushed
the
fix_race_coordinato
branch
from
5241883
to
9d7e741
Compare
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=========================================
- Coverage 96.57% 96.5% -0.07%
=========================================
Files 9 9
Lines 1722 1745 +23
=========================================
+ Hits 1663 1684 +21
- Misses 59 61 +2
Continue to review full report at Codecov.
|
tvoinarovskyi
force-pushed
the
fix_race_coordinato
branch
from
6fb2f9e
to
99964da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #88.