Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude_internal_topics option and fixed pattern subscription #111

Merged
merged 2 commits into from Feb 17, 2017

Conversation

tvoinarovskyi
Copy link
Member

Fixes #74

@tvoinarovskyi
Copy link
Member Author

Should also resolve #46 issue in case of group_id is not None.

@codecov-io
Copy link

codecov-io commented Feb 14, 2017

Codecov Report

Merging #111 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   96.53%   96.55%   +0.01%     
==========================================
  Files          10       10              
  Lines        1761     1771      +10     
==========================================
+ Hits         1700     1710      +10     
  Misses         61       61
Impacted Files Coverage Δ
aiokafka/group_coordinator.py 94.26% <100%> (+0.01%)
aiokafka/client.py 98.21% <100%> (+0.04%)
aiokafka/consumer.py 98.52% <100%> (+0.02%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70600d4...f0ae213. Read the comment docs.

@tvoinarovskyi tvoinarovskyi merged commit 09b9100 into master Feb 17, 2017
@tvoinarovskyi tvoinarovskyi deleted the exclude_internal_topics branch February 17, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants