Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connections_max_idle_ms propagation to connection instance. #299

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

tvoinarovskyi
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2018

Codecov Report

Merging #299 into master will decrease coverage by 0.84%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
- Coverage   98.44%   97.59%   -0.85%     
==========================================
  Files          21       21              
  Lines        3015     3164     +149     
==========================================
+ Hits         2968     3088     +120     
- Misses         47       76      +29
Impacted Files Coverage Δ
aiokafka/consumer/consumer.py 99.28% <ø> (ø) ⬆️
aiokafka/client.py 98.14% <ø> (ø) ⬆️
aiokafka/producer/producer.py 97.5% <ø> (ø) ⬆️
aiokafka/conn.py 85.71% <0%> (-13.68%) ⬇️
aiokafka/record/legacy_records.py 98.95% <0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5d2fc...a11d458. Read the comment docs.

@tvoinarovskyi tvoinarovskyi merged commit 84155e2 into master Jan 29, 2018
@tvoinarovskyi tvoinarovskyi deleted the fix_connections_max_idle_ms branch January 29, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant