Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.8 #669

Merged
merged 13 commits into from
Oct 21, 2020
Merged

Support Python 3.8 #669

merged 13 commits into from
Oct 21, 2020

Conversation

ods
Copy link
Collaborator

@ods ods commented Oct 21, 2020

Changes

Fixes #569

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #669 into master will increase coverage by 0.10%.
The diff coverage is 99.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   97.90%   98.01%   +0.10%     
==========================================
  Files          29       29              
  Lines        5114     5192      +78     
==========================================
+ Hits         5007     5089      +82     
+ Misses        107      103       -4     
Flag Coverage Δ
#cext 87.67% <98.69%> (+0.20%) ⬆️
#integration 97.97% <99.34%> (+0.10%) ⬆️
#purepy 97.53% <99.34%> (+0.11%) ⬆️
#unit 51.48% <42.48%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/producer/transaction_manager.py 98.32% <85.71%> (+0.02%) ⬆️
aiokafka/client.py 98.13% <100.00%> (+0.33%) ⬆️
aiokafka/conn.py 94.10% <100.00%> (+0.09%) ⬆️
aiokafka/consumer/consumer.py 97.90% <100.00%> (+<0.01%) ⬆️
aiokafka/consumer/fetcher.py 97.64% <100.00%> (+0.47%) ⬆️
aiokafka/consumer/group_coordinator.py 99.03% <100.00%> (ø)
aiokafka/consumer/subscription_state.py 100.00% <100.00%> (ø)
aiokafka/producer/message_accumulator.py 98.88% <100.00%> (+<0.01%) ⬆️
aiokafka/producer/producer.py 98.50% <100.00%> (+<0.01%) ⬆️
aiokafka/producer/sender.py 99.54% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc4354...cb3c9bc. Read the comment docs.

@@ -138,6 +139,20 @@ def session_id():
return str(uuid.uuid4())


@dataclass
class KafkaServer:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ods ods mentioned this pull request Oct 21, 2020
4 tasks
@ods ods requested a review from asvetlov October 21, 2020 18:14
@ods ods merged commit 48f5df5 into aio-libs:master Oct 21, 2020
@ods ods deleted the fixpy38 branch May 11, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings in asyncio with Python 3.8
2 participants