-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.8 #669
Support Python 3.8 #669
Conversation
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 97.90% 98.01% +0.10%
==========================================
Files 29 29
Lines 5114 5192 +78
==========================================
+ Hits 5007 5089 +82
+ Misses 107 103 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -138,6 +139,20 @@ def session_id(): | |||
return str(uuid.uuid4()) | |||
|
|||
|
|||
@dataclass | |||
class KafkaServer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
Fixes #569
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.