Add ssl support #81
Merged
Add ssl support #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.04% (diff: 100%)@@ master #81 diff @@
==========================================
Files 8 9 +1
Lines 1624 1696 +72
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1557 1629 +72
Misses 67 67
Partials 0 0
|
tvoinarovskyi
force-pushed
the
add_ssl
branch
from
e6b8962
to
a7214fa
Compare
fabregas
reviewed
Nov 23, 2016
| @@ -21,6 +24,36 @@ def docker(): | |||
| return libdocker.Client(version='auto') | |||
|
|
|||
|
|
|||
| @pytest.yield_fixture(scope='session') | |||
| def ssl_folder(docker_ip_address): | |||
There was a problem hiding this comment.
maybe we can generate and store (commit) ssl cert/key in tests/data for example... and use it in tests
| # Don't pull image if it available localy. Helps when developing new docker | ||
| # builds | ||
| if not docker.images(image): | ||
| docker.pull(image) |
There was a problem hiding this comment.
I have some pygo/kafka:2.11_0.9.0.1 image locally (pulled on previous make test in master).
If you (or somebody else) changes this image on docker hub, I'll never pull it (with this code).
For testing new docker builds you can use --docker-image option in pytest.
fabregas
reviewed
Nov 23, 2016
| request.cls.kafka_ssl_port = ksslport | ||
| request.cls.ssl_folder = ssl_folder | ||
|
|
||
| def _create_context(self): |
There was a problem hiding this comment.
why so implicit?) you pass ssl_folder to test class. So can implement this helper method in KafkaIntegrationTestCase class.
Reverted docker.pull to be run on tests whether you have or not image in docker, so we always update it to latest Other review fix
tvoinarovskyi
force-pushed
the
add_ssl
branch
from
529eb62
to
8658776
Compare
|
Fixes SSL part of #32 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.