Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security_protocol argument docstring #884

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

gabrielmbmb
Copy link
Contributor

Changes

Fixes #883

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@gabrielmbmb
Copy link
Contributor Author

Not sure what I have to do for the 4th check

@gabrielmbmb gabrielmbmb force-pushed the update_security_protocol_docstring branch from 0e4558d to 6232599 Compare April 11, 2023 09:11
@ods ods merged commit 577a54d into aio-libs:master Apr 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

security_protocol argument docstring does not mention SASL_SSL or SASL_PLAINTEXT
2 participants