Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send create/delete topics request to controller #996

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

ods
Copy link
Collaborator

@ods ods commented Apr 7, 2024

Changes

Fixes #995

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@ods ods marked this pull request as draft April 7, 2024 18:52
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.42%. Comparing base (1855cde) to head (8adb7b9).

Files Patch % Lines
aiokafka/admin/client.py 76.19% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
- Coverage   95.44%   95.42%   -0.03%     
==========================================
  Files         112      112              
  Lines       16702    16715      +13     
  Branches     2672     2675       +3     
==========================================
+ Hits        15942    15950       +8     
- Misses        479      483       +4     
- Partials      281      282       +1     
Flag Coverage Δ
cext 92.15% <77.27%> (-0.03%) ⬇️
integration 95.07% <77.27%> (-0.03%) ⬇️
purepy 94.89% <77.27%> (-0.03%) ⬇️
unit 52.64% <13.63%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods marked this pull request as ready for review April 14, 2024 15:51
@ods ods merged commit 2bba153 into aio-libs:master Apr 14, 2024
29 of 31 checks passed
@ods ods deleted the admin-to-controller branch April 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin client - failure to create topics (error code 41)
1 participant