Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max_size strict #14

Merged
merged 7 commits into from Sep 26, 2016
Merged

Make max_size strict #14

merged 7 commits into from Sep 26, 2016

Conversation

grant-aterlo
Copy link
Contributor

Make maxsize strict, switch to using a counter for the current size to avoid timing issues between connection created and connection added to in_use.

@asvetlov
Copy link
Member

Would you provide a test also?

@grant-aterlo
Copy link
Contributor Author

Test added, this broke the test for the behavior of releasing a connection when the pool is maxsize (this behavior should never be reached anymore).

@grant-aterlo
Copy link
Contributor Author

I am not sure why the CI build is failing, I can run the unittests fine with "make test" with python 3.5.

@coveralls
Copy link

coveralls commented Aug 5, 2016 •
edited

Coverage Status

Coverage remained the same at 43.651% when pulling ffae551 on grant-aterlo:master into ce39ba8 on aio-libs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.667% when pulling 35b736a on grant-aterlo:master into ce39ba8 on aio-libs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.667% when pulling 35b736a on grant-aterlo:master into ce39ba8 on aio-libs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.667% when pulling 35b736a on grant-aterlo:master into ce39ba8 on aio-libs:master.

@grant-aterlo
Fix unittests
8cd6731 
required:
1) Need delay after memcache server start
2) Reduce the exception retries on server start -- were crazy high
3) Use correct coverage name
@coveralls
Copy link

coveralls commented Aug 16, 2016 •
edited

Coverage Status

Coverage remained the same at 92.857% when pulling 8cd6731 on grant-aterlo:master into ce39ba8 on aio-libs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.582% when pulling da0afc9 on grant-aterlo:master into ce39ba8 on aio-libs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.582% when pulling da0afc9 on grant-aterlo:master into ce39ba8 on aio-libs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.582% when pulling da0afc9 on grant-aterlo:master into ce39ba8 on aio-libs:master.

@coveralls
Copy link

coveralls commented Aug 16, 2016 •
edited

Coverage Status

Coverage remained the same at 95.582% when pulling c7ddc27 on grant-aterlo:master into ce39ba8 on aio-libs:master.

@asvetlov asvetlov merged commit 40d25ea into aio-libs:master Sep 26, 2016
@asvetlov
Copy link
Member

Thanks and sorry for long answer

@argaen argaen mentioned this pull request Feb 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grant-aterlo @asvetlov @coveralls