Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gets cas commands #33

Merged
merged 4 commits into from Jan 26, 2017
Merged

Conversation

argaen
Copy link
Member

@argaen argaen commented Jan 26, 2017

@codecov-io
Copy link

codecov-io commented Jan 26, 2017

Current coverage is 88.27% (diff: 72.72%)

Merging #33 into master will decrease coverage by 2.88%

@@             master        #33   diff @@
==========================================
  Files             5          5          
  Lines           249        290    +41   
  Methods           0          0          
  Messages          0          0          
  Branches         38         49    +11   
==========================================
+ Hits            227        256    +29   
- Misses           11         17     +6   
- Partials         11         17     +6   

Powered by Codecov. Last update 6130c6d...5d95263

@fafhrd91 fafhrd91 merged commit 3553e4d into aio-libs:master Jan 26, 2017
@fafhrd91
Copy link
Member

thanks!

@argaen
Copy link
Member Author

argaen commented Jan 27, 2017

Np! I'll create a new PR increasing coverage or trying to merge repeated code this weekend if I have time :)

@fafhrd91
Copy link
Member

you should get invitation to aiomcache team, it has write access to aiomcache repo

@argaen
Copy link
Member Author

argaen commented Jan 27, 2017

Got it and accepted, thanks :)

@fafhrd91
Copy link
Member

Let's make another release after your changes to coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants