MySQL 8 Compatibility and SHA256 authentication plugin support #312
Conversation
Fixed unawaited authentication plugin coros
Fixed bug where used auth plugin was not updated
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 9 9
Lines 1119 1119
Branches 161 161
=======================================
Hits 1039 1039
Misses 56 56
Partials 24 24Continue to review full report at Codecov.
|
aiomysql/connection.py
Outdated
| else: | ||
|
|
||
| if plugin_name == b"mysql_native_password": |
There was a problem hiding this comment.
probably good idea move this block left and change else to elif
There was a problem hiding this comment.
Issue is we dont want to execute lines 831-833 when doing the sha256 plugins
|
It seems theres some weirdness/bug with pytest, fixture scoping and multiple sets of parameterisation... that or I couldn't find the magical combination to cause pytest not to spin up containers when it didn't need to. So I unrolled the parameterisation on test_sha_connection as that saves around 200 seconds. |
Pytest possibly has some bug in the fixture scoping when theres multiple sets of parameterisation Unrolling the test parameterisation for SHA meant less containers spun up and down.
| ) | ||
|
|
||
| # magic numbers: | ||
| # 2 - request public key |
There was a problem hiding this comment.
Good idea to make those numbers into enum, but I am fine merging PR as it is.
There was a problem hiding this comment.
I'd agree, but leaving them as they are does give us the benefit that it looks near identical to the equivalent pymysql function.
|
@jettify how do you go about doing a release to pypi? |
|
lets do this! |
|
Just create release https://github.com/aio-libs/aiomysql/releases here |
|
Cool we now have v0.0.18 |
|
Will test it out as soon as pypi updates their index (tomorrow?) P.S. what features will 0.1 have and what about 1.0 :P? |
|
@LemonPi A while ago we were thinking just jumping to 1.0.0 after we cleaned up the code a bit |
|
@terrycain 0.0.18 deploy failed https://travis-ci.com/aio-libs/aiomysql/builds/78487908, you need also bump version in I suggest bump version to 0.0.19 and create a new release. |
|
Or even maybe 0.1.0 version |
|
Ahh of course :D. Will bump 0.1.0 later today and rerelease |
|
Bumped version to 0.0.19 as I forgot about 0.1.0 when I was doing it :D We'll do 0.1.0 next time |
Fixes #302
Fixes #297
This PR contains the bulk of what PyMySQL 0.9.0 added which was support for MySQL 8+'s use of the
sha256_passwordandcaching_sha2_passwordauthentication plugin.I've also parameterised
mysql_tagso it now tests connecting to MySQL 5.6 and 8.0 using SSL and as MySQL 8 defaults to thecaching_sha2_password, that is tested by the current SSL unit tests.I'm planning on creating a fixture that allows me to skip tests depending on the value of
mysql_tagso I can target a few specific tests to 8.0 which should further test thesha256_passwordplugin.@jettify I'm assuming you have no issue with me making a PR to move the other tests to using the MySQL server provided by the container, that way I think we can get rid of all the travis matrix except PYTHONASYNCIODEBUG.
In the top of
conftest.pywere checking for version 3.5 and optionally enabling uvloop, seeing as we've dropped less than 3.5.3 support that can go.