Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning: 'ResultProxy' implements legacy __aiter__ protocol #394

Closed
Askaholic opened this issue Mar 25, 2019 · 4 comments · Fixed by #403
Closed

DeprecationWarning: 'ResultProxy' implements legacy __aiter__ protocol #394

Askaholic opened this issue Mar 25, 2019 · 4 comments · Fixed by #403
Labels
bug pr-merged

Comments

@Askaholic
Copy link
Contributor

Askaholic commented Mar 25, 2019 •
edited
Loading

Getting the following deprecation warning when using async for syntax in python 3.6.

DeprecationWarning: 'ResultProxy' implements legacy __aiter__ protocol; __aiter__ should return an asynchronous iterator, not awaitable.

Code:

async with engine.acquire() as conn:
    result = await conn.execute("SELECT <snip>")
    async for row in result:
        <snip>
@Askaholic Askaholic changed the title DeprecationWarning: 'ResultProxy' implements legacy __aiter__ protocol; When using async for syntax DeprecationWarning: 'ResultProxy' implements legacy __aiter__ protocol Mar 25, 2019
@Askaholic Askaholic mentioned this issue May 10, 2019
Merged
@helpr helpr bot added the pr-available label May 18, 2019
@helpr helpr bot added pr-merged and removed pr-available labels May 22, 2019
@jaggerwang
Copy link

@terrycain When this fix will be published to pip repo?

@Askaholic
Copy link
Contributor Author

@terrycain @thehesiod @jettify @asvetlov Any chance we can get a new bugfix version of aiomysql deployed?

@thehesiod
Copy link

sorry I'm not an admin on this project

@Askaholic
Copy link
Contributor Author

Do you know who is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix legacy __aiter__ methods Askaholic/aiomysql
4 participants
@jaggerwang @thehesiod @Askaholic @aio-libs-bot