To avoid AttributeError in function _request_authentication(self) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
| @@ -756,6 +756,9 @@ def _get_server_information(self): | |||
| i += salt_len | |||
|
|
|||
| i += 1 | |||
|
|
|||
| self._auth_plugin_name = '' | |||
There was a problem hiding this comment.
good catch! could you move this line to __init__ block ?
ttlttl
force-pushed
the
Fix-auth-error
branch
from
21025e0
to
d02b4a2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I use aiomysql 0.0.8 on Window10 x64 using Python3.5.2 to connect mysql server( version 5.1.73) on Centos6.4 x64, I got:
_File "G:\git\aiowebapp.env\lib\site-packages\aiomysql\connection.py", line 657, in _request_authentication
if self._auth_plugin_name in ('', 'mysql_native_password'):
AttributeError: 'Connection' object has no attribute 'auth_plugin_name'
I checked the Server Greeting wirshark cap, found the "PLUGIN_AUTH" bit in "server capabilities" is 0, which means "self.server_capabilities & CLIENT.PLUGIN_AUTH" is False in function "_get_server_information(self)", so attribute 'auth_plugin_name' is undefined here.
And then the "AttributeError" occur in
_request_authentication(self): if self.server_capabilities & CLIENT.PLUGIN_AUTH:And when I do this fix, the aiomysql works well!
Best Regards
Mingming