Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor pymysql byte/int utils #554

Closed
wants to merge 1 commit into from

Conversation

zzzeek
Copy link

@zzzeek zzzeek commented Jan 7, 2021

PyMySQL 1.0.0 has removed the util.py module as well as some utilities from connections.py; vendor the small set of very short functions locally and open up requirements to support PyMySQL 1.0.0

PyMySQL 1.0.0 has removed the util.py module as well
as some utilities from connections.py; vendor
the small set of very short functions locally
and open up requirements to support PyMySQL 1.0.0
@Nothing4You
Copy link
Collaborator

hi,

thanks for the PR.

could you please reduce this to just vendoring pack_int24 and lenenc_int?
they should also be prefixed with underscores, as we do not want to add them to our public API.
the other methods should not be needed anymore and they should get removed in #643.

this change alone will still be compatible with PyMySQL <1.0.0, so if you remove bumping the PyMySQL version it will be compatible independently from merging #643.

@Nothing4You Nothing4You added this to the 1.0 milestone Jan 29, 2022
@Nothing4You Nothing4You added the pymysql-port Awaiting or implementing port of PyMySQL change label Jan 29, 2022
@zzzeek
Copy link
Author

zzzeek commented Jan 29, 2022

I wont have time to refine this patch in the ways you seek so feel free to take over and/or close.

@Nothing4You
Copy link
Collaborator

no worries, thank you anyways.
I'll close this in favor of #643.

@Nothing4You Nothing4You removed this from the 1.0 milestone Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pymysql pymysql-port Awaiting or implementing port of PyMySQL change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants