add xfailing test case for #545 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is ported from PyMySQL/PyMySQL#450, also adds a test case for Cursor.execute()
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 92.66% 92.69% +0.02%
==========================================
Files 35 35
Lines 5413 5434 +21
Branches 584 586 +2
==========================================
+ Hits 5016 5037 +21
Misses 309 309
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nothing4You
added a commit
that referenced
this pull request
Jan 30, 2022
while we do not yet strictly require it this simplifies maintenance. e.g. the xfailing test from #712 gets a different error type starting with PyMySQL 0.10.0. it will also allow us to adopt the backwards incompatible changes from PyMySQL 0.10 and 1.0. as our test suite only runs with the latest supported PyMySQL version we currently cannot reliably test older versions either.
4 tasks
Nothing4You
added a commit
that referenced
this pull request
Jan 30, 2022
while we do not yet strictly require it this simplifies maintenance. e.g. the xfailing test from #712 gets a different error type starting with PyMySQL 0.10.0. it will also allow us to adopt the backwards incompatible changes from PyMySQL 0.10 and 1.0. as our test suite only runs with the latest supported PyMySQL version we currently cannot reliably test older versions either.
Nothing4You
added
pymysql
pymysql-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
add xfailing test case for #545
this is ported from PyMySQL/PyMySQL#450, also adds a test case for Cursor.execute()
Are there changes in behavior for the user?
no
Related issue number
#545
Checklist
CHANGES.txt