Fix SSCursor raising query timeout error on wrong query on MySQL DB #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing4You
added
bug
pymysql-port
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 92.84% 92.74% -0.10%
==========================================
Files 38 38
Lines 5551 5558 +7
Branches 941 942 +1
==========================================
+ Hits 5154 5155 +1
- Misses 309 315 +6
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nothing4You
force-pushed
the
port-pymysql-1035
branch
from
1ec8bdb
to
b3d61f1
Compare
andr-04
added a commit
to andr-04/aiomysql
that referenced
this pull request
May 13, 2022
* commit '8a32f052a16dc3886af54b98f4d91d95862bfb8e': (92 commits) Update changelog for 0.1.1 release (aio-libs#784) Bump pytest from 7.1.1 to 7.1.2 (aio-libs#781) XFail test_issue_36 for now to avoid failing for unrelated changes (aio-libs#779) Skip codecov uploads in scheduled daily tests (aio-libs#778) Bump codecov/codecov-action from 3.0.0 to 3.1.0 (aio-libs#777) Fix SSL connection handshake charset not respecting client configuration (aio-libs#776) Bump ncipollo/release-action from 1.9.0 to 1.10.0 (aio-libs#766) Bump actions/cache from 3.0.1 to 3.0.2 (aio-libs#771) Bump actions/download-artifact from 2 to 3 (aio-libs#765) Bump actions/upload-artifact from 2 to 3 (aio-libs#767) Update changelog for release (aio-libs#769) Checkout git source to access changelog for GitHub release creation Change next version to 0.1.0 in changelog Fix GHA badge in readme after aio-libs#734 (aio-libs#762) Fix SSCursor raising query timeout error on wrong query on MySQL DB (aio-libs#761) Specify explicit language for literal blocks in CONTRIBUTING.rst to reduce warnings in doc builds (aio-libs#760) fix `make checkrst` (aio-libs#759) Update sphinx requirement from <4.4.1,>=1.8.1 to 4.5.0 (aio-libs#751) Bump codecov/codecov-action from 2.1.0 to 3.0.0 (aio-libs#758) Bump actions/cache from 2.1.7 to 3.0.1 (aio-libs#752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Ports PyMySQL/PyMySQL@dd0f854 from PyMySQL/PyMySQL#1035.
See PyMySQL/PyMySQL#1032 (comment) for a full explanation of the issue.
Tests for this are not included due to the seemingly non-deterministic behavior.
Are there changes in behavior for the user?
Query timeout errors are ignored on SSCursor, rather than raising on subsequent, unrelated queries.
Related issue number
fixes #428
Checklist
CHANGES.txt