Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default minsize for pool to 1 #80

Merged
merged 1 commit into from
Jun 2, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions aiomysql/pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
_PoolAcquireContextManager)


def create_pool(minsize=10, maxsize=10, echo=False, loop=None, **kwargs):
def create_pool(minsize=1, maxsize=10, echo=False, loop=None, **kwargs):
coro = _create_pool(minsize=minsize, maxsize=maxsize, echo=echo,
loop=loop, **kwargs)
return _PoolContextManager(coro)


@asyncio.coroutine
def _create_pool(minsize=10, maxsize=10, echo=False, loop=None, **kwargs):
def _create_pool(minsize=1, maxsize=10, echo=False, loop=None, **kwargs):
if loop is None:
loop = asyncio.get_event_loop()

Expand Down
4 changes: 2 additions & 2 deletions aiomysql/sa/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
_dialect.default_paramstyle = 'pyformat'


def create_engine(minsize=10, maxsize=10, loop=None,
def create_engine(minsize=1, maxsize=10, loop=None,
dialect=_dialect, **kwargs):
"""A coroutine for Engine creation.

Expand All @@ -32,7 +32,7 @@ def create_engine(minsize=10, maxsize=10, loop=None,


@asyncio.coroutine
def _create_engine(minsize=10, maxsize=10, loop=None,
def _create_engine(minsize=1, maxsize=10, loop=None,
dialect=_dialect, **kwargs):

if loop is None:
Expand Down
2 changes: 2 additions & 0 deletions tests/sa/test_sa_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,14 @@ def make_engine(self, use_loop=True, **kwargs):
password=self.password,
host=self.host,
loop=self.loop,
minsize=10,
**kwargs))
else:
return (yield from sa.create_engine(db=self.db,
user=self.user,
password=self.password,
host=self.host,
minsize=10,
**kwargs))

@asyncio.coroutine
Expand Down
1 change: 1 addition & 0 deletions tests/test_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ def connect(self, host=None, user=None, password=None,

@asyncio.coroutine
def create_pool(self, no_loop=False, use_unicode=True, **kwargs):
kwargs.setdefault("minsize", 10)
loop = None if no_loop else self.loop
pool = yield from aiomysql.create_pool(loop=loop,
host=self.host,
Expand Down