Closing connection object throws exception

[sumerc]

Hi,

I am using aiopg with a Pool object that is shared among coroutines. Every once in a while, randomly I see following error:

psycopg2.ProgrammingError: close cannot be used while an asynchronous query is u
nderway

I can reproduce the issue with following:

pool = yield from aiopg.create_pool(dsn)
with (yield from pool.cursor(timeout=1.0)) as cur:
    yield from cur.execute("SELECT pg_sleep(2)")

It seems valid to raise TimeoutError rather than ProgrammingError, I believe. What do you think?

Thanks,

[asvetlov]

Got it.

[kashifrazzaqui]

We are also facing this issue, can you please patch this. We don't specify a timeout value though.

Specifically for us it occurs when we pass a 'sub-query' to cursor.execute

[asvetlov]

What do you mean by sub-query?
cusor object is intended to execute only one query in the same time.

[kashifrazzaqui]

http://www.postgresql.org/docs/8.2/static/functions-subquery.html

[bitdancer]

Changing this from a ProgrammingError to a TimeoutError seems to have been done in 8ca948e, which also makes sure the connection and cursor are closed when it happens. Can this issue be closed?

[asvetlov]

Not yet. I should fix closing cursor with pending query first.
Will do it next week -- just after making new aiohttp release.

[sumerc]

Do we have any estimate for the fix? If sub-query is hard to implement, I think we should include the initial problem as soonn as possible. Because currently this blocks one from implementing a retry policy on specific DB errors. e.g: retry query on TimeOut Error 2 times.

[asvetlov]

Fixed, d0e5f86 has explicit test for the issue