Add pool_recycle keyword argument to Pool. #366
Conversation
aiopg/pool.py
Outdated
|
|
||
| # Close connections that have lived longer than the recycle limit. | ||
| if conn in self._free_timestamps: | ||
| now = datetime.datetime.now() |
aiopg/pool.py
Outdated
| self._conn_kwargs = kwargs | ||
| self._acquiring = 0 | ||
| self._free = collections.deque(maxlen=maxsize or None) | ||
| self._free_timestamps = {} |
There was a problem hiding this comment.
I suggest storing timestamp into connection object
There was a problem hiding this comment.
I was thinking about that, but Connection doesn't know whether it's free or not at the moment, that I can tell. You'd be happy with an additional attribute which only gets updated through the pool?
I was going to add a free method to Connection to handle updating the time
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 93.49% 93.54% +0.05%
==========================================
Files 23 23
Lines 3550 3578 +28
Branches 205 208 +3
==========================================
+ Hits 3319 3347 +28
Misses 186 186
Partials 45 45
Continue to review full report at Codecov.
|
|
Just to note, I've made changes according to the comments/requested changes, though I'm not sure if this is 100% what you meant slash if there are other places or concerns that I've missed which could get the connection out of sync with the pool |
|
closing because #373 seems to do the same thing better! |
Add a pool_recycle option similar to the optional available in sqlalchemy