fix: Fix the testcase that isn't applicable to all python version. (#307

)

* fix: Fix the testcase that isn't applicable to all python version.

* One of the test cases are testing a bug in Python stdlib that was
  fixed in 3.10 and backported to 3.9 and 3.8. This updates the
  version check to make it pass on all supported versions.
* Bump dependency on actions/setup-python@v4 to support pypy3.7
* Add dependency on 'py' to fix the non-declared dependency in
  pytest-sugar.

* Remove dependency for CI on qa

* Use pypy3.7 for testing since pypy3.6 is no longer supported

* Use pypy3.6 for testing

* revert: Re-add dependency on qa for Unit testing

* fix: some flake8 errors after rebase

* fix: update the expected response after QA fixes

.github/workflows/unit-testing-and-coverage.yml

@@ -89,7 +89,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ "macos-10.15", "ubuntu-18.04", "ubuntu-20.04", "windows-latest" ]
-        python-version: [ "3.6", "3.7", "3.8", "3.9", "pypy3" ]
+        python-version: [ "3.6", "3.7", "3.8", "3.9", "pypy3.6" ]
     runs-on: ${{ matrix.os }}
     timeout-minutes: 15  # Slowest so far is pypy3 on MacOS, taking almost 7m
     steps:
@@ -98,7 +98,7 @@ jobs:
       with:
         fetch-depth: 0  # Required by codecov/codecov-action@v1
     - name: "Set up Python ${{ matrix.python-version }}"
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: "Install dependencies"

aiosmtpd/tests/test_handlers.py

@@ -821,7 +821,7 @@ def test_oserror(
             if rt == (
                 logger_name,
                 logging.INFO,
-                "we got some refusals: {'bart@example.com': (-1, 'ignore')}",
+                "we got some refusals: {'bart@example.com': (-1, b'ignore')}",
             ):
                 break
         else:

aiosmtpd/tests/test_smtp.py

@@ -7,6 +7,7 @@
 import itertools
 import logging
 import socket
+import sys
 import time
 import warnings
 from asyncio.transports import Transport
@@ -1060,7 +1061,12 @@ def test_byclient(
         client.user = "goodlogin"
         client.password = PW
         auth_meth = getattr(client, "auth_" + mechanism)
-        if (mechanism, init_resp) == ("login", False):
+        if (mechanism, init_resp) == ("login", False) and (
+                sys.version_info < (3, 8, 9)
+                or (3, 9, 0) < sys.version_info < (3, 9, 4)):
+            # The bug with SMTP.auth_login was fixed in Python 3.10 and backported
+            # to 3.9.4 and and 3.8.9.
+            # See https://github.com/python/cpython/pull/24118 for the fixes.:
             with pytest.raises(SMTPAuthenticationError):
                 client.auth(mechanism, auth_meth, initial_response_ok=init_resp)
             client.docmd("*")

tox.ini

@@ -39,6 +39,7 @@ deps =
     pytest-print
     pytest-profiling
     pytest-sugar
+    py # needed for pytest-sugar as it doesn't declare dependency on it.
     diff_cover
 setenv =
     cov: COVERAGE_FILE={toxinidir}/_dump/.coverage