Block release if git unclean (#366)

* Stop release process if repo is not clean
* Update test_release_date
  Now can match versions with alphanumeric suffixes
* Give last chance to cancel upload after build
* Bump version to 1.4.4.post2

aiosmtpd/__init__.py

@@ -4,7 +4,7 @@
 import warnings
 
 
-__version__ = "1.4.4"
+__version__ = "1.4.4.post2"
 
 
 def _get_or_new_eventloop() -> asyncio.AbstractEventLoop:

aiosmtpd/docs/NEWS.rst

@@ -16,6 +16,15 @@ Fixed/Improved
 * A whole bunch of annotations
 
 
+1.4.4.post2 (2023-01-19)
+========================
+
+Fixed/Improved
+--------------
+* Prevent unclean repo from being built (Closes #365)
+* Reduce chance of not-ready-for-release packages from being uploaded
+
+
 1.4.4 (2023-01-17)
 ==================
 

aiosmtpd/qa/test_0packaging.py

@@ -17,7 +17,7 @@
 from aiosmtpd import __version__
 
 RE_DUNDERVER = re.compile(r"__version__\s*?=\s*?(['\"])(?P<ver>[^'\"]+)\1\s*$")
-RE_VERHEADING = re.compile(r"(?P<ver>[0-9.]+)\s*\((?P<date>[^)]+)\)")
+RE_VERHEADING = re.compile(r"(?P<ver>([0-9.]+)\S*)\s*\((?P<date>[^)]+)\)")
 
 
 @pytest.fixture

release.py

@@ -19,6 +19,12 @@
 printfl = partial(print, flush=True)
 run_hidden = partial(subprocess.run, stdout=subprocess.PIPE)
 
+result = run_hidden(shlex.split("git status --porcelain"))
+if result.stdout:
+    print("git is not clean!")
+    print("Please commit/shelf first before releasing!")
+    sys.exit(1)
+
 TWINE_CONFIG = Path(os.environ.get("TWINE_CONFIG", "~/.pypirc")).expanduser()
 TWINE_REPO = os.environ.get("TWINE_REPOSITORY", "aiosmtpd")
 UPSTREAM_REMOTE = os.environ.get("UPSTREAM_REMOTE", "upstream")
@@ -101,7 +107,16 @@
     # Assuming twine is installed.
     print("### twine check")
     subprocess.run(["twine", "check"] + DISTFILES, check=True)
+except subprocess.CalledProcessError as e:
+    print("ERROR: Last step returned exitcode != 0")
+    sys.exit(e.returncode)
+
+choice = input("Ready to upload to PyPI? [y/N]: ")
+if choice.casefold() not in ("y", "yes"):
+    print("Okay.")
+    sys.exit(0)
 
+try:
     # You should have an aiosmtpd bit setup in your ~/.pypirc - for twine
     twine_up = f"twine upload --config-file {TWINE_CONFIG} -r {TWINE_REPO}".split()
     if GPG_SIGNING_ID: