Skip to content

Commit

Permalink
Limit CI runtime
Browse files Browse the repository at this point in the history 
Slowest so far is pypy3 on MacOS, which took almost 7 minutes.

Thus setting the timeout to 15 minutes should be enough for our needs,
now and in the (mid) future.

One day we might have to revisit this, but nowhere soon.
  • Loading branch information
@pepoluan
pepoluan committed Mar 3, 2021
1 parent 1069341 commit c52d3b6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/unit-testing-and-coverage.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ jobs:
os: [ "macos-10.15", "ubuntu-18.04", "ubuntu-20.04", "windows-latest" ]
python-version: [ "3.6", "3.7", "3.8", "3.9", "pypy3" ]
runs-on: ${{ matrix.os }}
timeout-minutes: 15 # Slowest so far is pypy3 on MacOS, taking almost 7m
steps:
- name: "Checkout latest commit"
uses: actions/checkout@v2
Expand Down

1 comment on commit c52d3b6

@pepoluan
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented this limit after experiencing some Actions that took waaaay too long to produce a result (and failed in the end; a test case seemed to be stuck for unclear reasons).

The default is 360 minutes (6 hours), meaning that PRs/commits with stuck test cases remained yellow until 6 hours have passed, that messes up the "rapid iterative development" we have been doing lately. Shortening it to 15 minutes means after at most 15 minutes we'll get a result, be it Pass or Fail. And if the latter, we can quickly iterate.

(I'm trying to implement an "All Green at Day Closing" objective.)

Please sign in to comment.