Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of __ident__ field in SMTP class #131

Closed
kz26 opened this issue Oct 8, 2017 · 1 comment
Closed

Allow customization of __ident__ field in SMTP class #131

kz26 opened this issue Oct 8, 2017 · 1 comment
Labels
API integration tech-debt Things that needs to be tidied up to avoid being bitten in the future...

Comments

@kz26
Copy link
Contributor

kz26 commented Oct 8, 2017 •
edited
Loading

It would be useful to refactor ident into a customizable field on the SMTP class, e.g. if you want to hide the fact that the server is Python-powered.
@warsaw warsaw added API integration tech-debt Things that needs to be tidied up to avoid being bitten in the future... labels Oct 9, 2017
@Mortal
Copy link
Contributor

Mortal commented Oct 9, 2017

Indeed, this is currently not well supported.

I think the right approach would be to introduce a hook for when the connection has been established.

As a workaround, you can import aiosmtpd.smtp and write to aiosmtpd.smtp.__ident__ directly.

@kz26 kz26 mentioned this issue Oct 12, 2017
Merged
@warsaw warsaw closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API integration tech-debt Things that needs to be tidied up to avoid being bitten in the future...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@warsaw @Mortal @kz26