-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add STARTTLS support to aiosmtpd cli #172
Comments
I would be 👍 on a PR that implemented this feature. Looking at https://aiosmtpd.readthedocs.io/en/latest/aiosmtpd/docs/smtp.html#enabling-starttls I think if we had the flags:
the presence of which add the the context, that would be awesome. Obviously we would want requiretls to be an invalid option if cert & key weren't present, the presence of either cert or key without the other should be an error. @dkg would you be interested and able to work on this? |
While we're at it, should we also add support for SMTPS? If so, we'll need to add these options:
|
I'm implementing this right now in a branch (not yet pushed) One change from the above discussion: |
I think that's a good idea but that will break backwards compatibility, right? |
Well... no? Because originally there was no There isn't even support for SMTPS/STARTTLS for cli ... so I'm adding to a practical green field. My note up there was just explaining my decision to implement |
Ah -- well never mind then 😂 |
It would be great to be able to have the aiosmtpd cli support offering STARTTLS.
The text was updated successfully, but these errors were encountered: